[PATCH] Review request for plasma marble wallpaper (playground)

[Frederik Gladhorn]

Hi Sascha,
thanks for looking at the marble wallpaper - that's much appreciated from my 
side :)
I have had no time to look at the patch at all yet, will do so on the weekend.

On Monday 15 December 2008 21:41:16 Sascha Peilicke wrote:
> For Frederic Gladhorn and FYI.
>
>
> This patch adds/changes a lot of features to the marble plasma wallpaper in
> playground.
>
> Re-enabled the stars plugin as current Marble trunk doesn't seem to crash
> on it any further.
Seems good to me, I enabled it again here and have had no trouble with it 
lately.

> Moved to a more generic support for globe rotation schemes to allow
> something like "hover on home location" or free rotation (with the marble
> navigation plugin).
>
> Mouse interaction was removed completely, this caused all sort of weird
> troubles when interacting with plasma widgets (instead rotates the globe or
> vice versa). Mouse scrolling previously used for zooming the globe is also
> otherwise reserved for switching workspaces. Instead the user can enable
> the marble navigation widget to zoom/rotate the globe.

I had not a single weird interaction - you just need to differentiate between 
applet and wallpaper and you'll be fine.
This is the change that I don't agree with. For me the wallpaper is all about 
being fancy-interactive-hotness and it's sole purpose is to brag about KDE 
hotness with it.
Many people hate the wheel on workspace option, I don't have a strong opinion 
either way, but I think the wheel is much better used to zoom here.
This wallpaper doesn't bring speed or a faster work flow - it is just a toy, 
so people using the wheel to switch desktops won't use this wallpaper I guess.
My problem with the marble navigation widgets is that they clutter the 
desktop. I want to see that globe thingy, not lots of controls.
Maybe a checkbox to enable mouse interaction? More options ftw...?
I started it to show a friend who had something similar once upon a time in 
some proprietary environment how flexible and great our frameworks are.
I'd even like to open a browser with the placemarks - same as marble does.
Wikipedia ftw.

> Reworked the configuration screen to show only options which make sense
> together. This means some values are shown and hidden based on selected
> globe rotation behavior, marble theme etc. More generic "show placemarks" 
> instead of "show night, show citylights, show places" to not present too
> much config detail to the user.
Very good, I just threw in every marble option I could find ;) making it more 
understandable is a good idea.

> Maybe we should also change the name from "The Earth" to something more
> descriptive or just "Marble globe" to advertise this great technology ^^
See Aarons reply, I'm fine with Globe, I'm a little against putting Marble 
here.

> There still remains some work on tweaking zoom/rotate/pan to stop the user
> from scrolling over the maps _edges_ on flat map projections (looks not too
> nice currently).  The patch mixes code cleanup and feature changes, but
> being in playground and in early development stage, I was just too lazy to
> produce distinct patches :-)

Greetings
Frederik


>
> Affected files:
>
> 	playground/base/plasma/wallpapers/marble/config.ui
> 	playground/base/plasma/wallpapers/marble/marble.cpp
> 	playground/base/plasma/wallpapers/marble/marble.h
> 	playground/base/plasma/wallpapers/marble/CMakeLists.txt
> 	playground/base/plasma/wallpapers/CMakeLists.txt