Review Request: Drag taskbar entries into the pager

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/312/#review301
-----------------------------------------------------------

Ship it!


looks good, except for a few style oopses (braces should be on the same line as the conditional).

probably a good time to also get rid of the horrid "taskbar/taskItemWId" type ... hm ... plasma/wid? tasks/wid? windowsystem/winid? yeah, i like that last one best. i'll make that change now in the tasks widget.

anyways, i'm not sure this can go into 4.2 due to the feature freeze ... *thinks* we could creatively call it completing the tasks widget drag feature? =)

i remember when this went into kicker and people were telling me i was crazy. fun to see another one of the old features make it back in ;)

- Aaron


On 2008-12-16 14:38:29, Albert Astals Cid wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.vidsolbach.de/r/312/
> -----------------------------------------------------------
> 
> (Updated 2008-12-16 14:38:29)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Adds to KDE 4 the missing feature of being able to drag taskbar entries into the pager to move them between desktops
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/plasma/applets/pager/pager.h
>   /trunk/KDE/kdebase/workspace/plasma/applets/pager/pager.cpp
>   /trunk/KDE/kdebase/workspace/plasma/applets/tasks/abstracttaskitem.h
>   /trunk/KDE/kdebase/workspace/plasma/applets/tasks/abstracttaskitem.cpp
>   /trunk/KDE/kdebase/workspace/plasma/applets/tasks/windowtaskitem.h
>   /trunk/KDE/kdebase/workspace/plasma/applets/tasks/windowtaskitem.cpp
> 
> Diff: http://reviewboard.vidsolbach.de/r/312/diff
> 
> 
> Testing
> -------
> 
> Played with it for a while and did not explode
> 
> 
> Thanks,
> 
> Albert
> 
>