[PATCH] Review request for plasma marble wallpaper (playground)

Sascha Peilicke sasch.pe at gmx.de
Mon Dec 15 21:41:16 CET 2008


For Frederic Gladhorn and FYI.


This patch adds/changes a lot of features to the marble plasma wallpaper in 
playground. 

Re-enabled the stars plugin as current Marble trunk doesn't seem to crash on 
it any further.

Moved to a more generic support for globe rotation schemes to allow something 
like "hover on home location" or free rotation (with the marble navigation 
plugin).

Mouse interaction was removed completely, this caused all sort of weird 
troubles when interacting with plasma widgets (instead rotates the globe or 
vice versa). Mouse scrolling previously used for zooming the globe is also 
otherwise reserved for switching workspaces. Instead the user can enable the 
marble navigation widget to zoom/rotate the globe.

Reworked the configuration screen to show only options which make sense 
together. This means some values are shown and hidden based on selected globe 
rotation behavior, marble theme etc. More generic "show placemarks"  instead 
of "show night, show citylights, show places" to not present too much config 
detail to the user.
 
Maybe we should also change the name from "The Earth" to something more 
descriptive or just "Marble globe" to advertise this great technology ^^

There still remains some work on tweaking zoom/rotate/pan to stop the user 
from scrolling over the maps _edges_ on flat map projections (looks not too 
nice currently).  The patch mixes code cleanup and feature changes, but being 
in playground and in early development stage, I was just too lazy to produce 
distinct patches :-)


Affected files:

	playground/base/plasma/wallpapers/marble/config.ui
	playground/base/plasma/wallpapers/marble/marble.cpp
	playground/base/plasma/wallpapers/marble/marble.h
	playground/base/plasma/wallpapers/marble/CMakeLists.txt
	playground/base/plasma/wallpapers/CMakeLists.txt

-- 
Sascha Peilicke
http://saschpe.wordpress.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: marblewallpaper-refactor.patch
Type: text/x-patch
Size: 39241 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/plasma-devel/attachments/20081215/8ff5ae2d/attachment-0001.patch 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/plasma-devel/attachments/20081215/8ff5ae2d/attachment-0001.sig 


More information about the Plasma-devel mailing list