Review Request: Make folderview follow some guidelines

[Artur (MoRpHeUz)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/307/
-----------------------------------------------------------

(Updated 2008-12-13 23:29:45.405694)


Review request for Plasma, Anne-Marie Mahfouf and Aaron Seigo.


Summary
-------

This follows aseigo's ideas:

a) if it's user placed plasmoid, it should always default to $HOME

b) the one we create automatically at the start in the plasma desktop shell defaults to $DESKTOP if it exists (and isn't $HOME) as a compromise position --> (this one is done by desktopcorona.cpp)

c) when it's a containment, it should default to $DESKTOP if it exists (and isn't $HOME) since that is a legacy compatibility mode
d) in no circumstances should plasma trigger the creation of a $DESKTOP folder path if it doesn't point to something valid


We still have to change the description of folderview when we unfreeze the strings, making bug 175824 invalid.

Removed the warning from the configuration UI too. If we want to warn the user that it will show the home folder if the desktop folder doesnt exist, we can add this later in 4.3 as it implies in string change.


This addresses bugs 175824 and 176652.


Diffs
-----

  /trunk/KDE/kdebase/apps/plasma/applets/folderview/folderview.cpp
  /trunk/KDE/kdebase/apps/plasma/applets/folderview/folderviewLocationConfig.ui

Diff: http://reviewboard.vidsolbach.de/r/307/diff


Testing
-------

Tested with trunk in different situations. Important to say that we have a new bug: if the user changes the desktop path in "Settings>>About me", the folderview pointing to desktop:/ is not refreshed.


Thanks,

Artur