Review Request: Allow width of Now Playing applet to change when resizing containment

Tony Murray murraytony at gmail.com
Fri Dec 12 16:13:41 CET 2008


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/301/
-----------------------------------------------------------

Review request for Plasma.


Summary
-------

This is a crude fix, but it is fairly minimal.  I'm not sure how correct it is.

Issues still remain including: the buttons being smaller than they could be and it is hard coded for two buttons on the panel, but this could be changed later if the user is allowed to change what buttons are displayed.

Also, I would like to add a tooltip with the current track information, but that would be a different patch and takes more knowledge of the applet API than I currently have ;)


Diffs
-----

  /trunk/KDE/kdeplasma-addons/applets/nowplaying/nowplaying.cpp

Diff: http://reviewboard.vidsolbach.de/r/301/diff


Testing
-------

Just on my local machine.  At least it doesn't cause a loop like using resize in constraintsEvent() does ;)


Thanks,

Tony



More information about the Plasma-devel mailing list