Review Request: correct panel placement when clicking Add Panel

Marco Martin notmart at gmail.com
Wed Dec 10 14:05:03 CET 2008


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/297/#review286
-----------------------------------------------------------

Ship it!


tried it and it works well, seems also simple enough, ok from me.
aaron, is it ok?

- Marco


On 2008-12-10 03:30:38, Alessandro Diaferia wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.vidsolbach.de/r/297/
> -----------------------------------------------------------
> 
> (Updated 2008-12-10 03:30:38)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> This patch tries to place correctly the panel filling the free edges in the current screen.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdebase/workspace/plasma/containments/desktop/CMakeLists.txt
>   trunk/KDE/kdebase/workspace/plasma/containments/desktop/desktop.cpp
>   trunk/KDE/kdebase/workspace/plasma/containments/panel/panel.cpp
>   trunk/KDE/kdelibs/plasma/corona.h
>   trunk/KDE/kdelibs/plasma/corona.cpp
> 
> Diff: http://reviewboard.vidsolbach.de/r/297/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alessandro
> 
>



More information about the Plasma-devel mailing list