PATCH for improve the panel action(bug num:177219)

Aaron J. Seigo aseigo at kde.org
Mon Dec 8 15:15:20 CET 2008


On Monday 08 December 2008, zhangqiang wrote:
> In order to help general users.I make a patch.I don't know whether it is
> needed and suitable.That is, if the user deletes the last panel,give the
> tip "This is the last panel! Make sure you know how to add it.",that is
> unlike the usual tip "Do you really want to remove the panel ?" I do it in
> the containment, and my patch attached. Thanks very much.

first, we can't make such a change until trunk opens for 4.3 development as it 
contains new strings.

the patch, however, is also incorrect in a few ways: not all panel 
containments are called "panel", and keeping a count is unecessary.

instead, simply loop through Corona::containments() and look for 
containmentType() == PanelContainment or CustomPanelContainment

moreover, i don't think this belongs in libplasma since not all plasma based 
applications will care about this. it really belongs in the desktop shell 
application.

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Software

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20081208/d97a5589/attachment.htm 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/plasma-devel/attachments/20081208/d97a5589/attachment.sig 


More information about the Plasma-devel mailing list