New to list, make in applet

[Aaron J. Seigo]

On Sunday 07 December 2008, David Baron wrote:xperimental and backports.
> > > While the code is not voluminous, it is longer than appropriate for
> > > such a posting. If the list permits inclusions, I can do so.

some things that pop out at me:

* neat idea and something that i'm sure many will find useful ... 

* instead of having all those different svg's, you could put all the elements 
into just one svg. more efficient all around, and probably save your applet a 
few lines of code. obviously not critical =)

* lots of C like code in there, such as dealing with c strings. never fun 
compared to Qt ;)

* popupPosition is probably wrong because you are calling it before setupUi is 
called and so the size of the dialog is incorrect. also, if you move the 
applet the position the position will be incorrect. so i'd recommend move the 
popupPosition call to ToggleGUI where you show it. (well, only when it's about 
to be shown, obviously; no point in moving it when it's just going to be 
hidden =)

* for the crashes, try your applet in plasmoidviewer (plasmoidviewer 
<pluginName>) and see if you can get a backtrace from that. note that 
plasmoidviewer does store the settings, so it's a fine way to emulate "on next 
login"

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Software


-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20081207/0e88bab5/attachment.htm 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/plasma-devel/attachments/20081207/0e88bab5/attachment.sig