Review Request: Bugfix for Folderview bug #175191

Fredrik Höglund fredrik at kde.org
Thu Dec 4 17:59:07 CET 2008


On Sunday 30 November 2008 18:20, Aaron Seigo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.vidsolbach.de/r/288/#review276
> -----------------------------------------------------------
> 
> Ship it!
> 
> 
> yes, that's probably sensible.
> 
> 
> /trunk/KDE/kdebase/apps/plasma/applets/folderview/folderview.cpp
> <http://reviewboard.vidsolbach.de/r/288/#comment228>
> 
>     i'm a little surprised that setUrl doesn't call dirListed()->openUrl or updateIconWidget, but Frederik could probably explain why =)

I actually can't explain that because I didn't write that particular method ;)

But I think it's a bit of a misnomer because what it really does is update
the icon view label.

Regards,
Fredrik



More information about the Plasma-devel mailing list