Review Request: Another Plasma::Svg speedup

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/291/#review281
-----------------------------------------------------------

Ship it!


well, approving this one is a no-brainer :) nice catch.

please, with these kinds of obvious fixes, feel free to just commit; we can review these sorts of things post-commit on the commit log mailing list.

- Aaron


On 2008-12-02 07:20:42, Alain Boyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.vidsolbach.de/r/291/
> -----------------------------------------------------------
> 
> (Updated 2008-12-02 07:20:42)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> This patch makes use of the localRectCache in hasElement().
> 
> I came across this when looking into the painting performance of the analog clock applet. In this case, I see a 6.67 speedup when calling Svg::hasElement().
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/plasma/svg.cpp
> 
> Diff: http://reviewboard.vidsolbach.de/r/291/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alain
> 
>