Review Request: This patch add an easy way to up/down brightness only scrolling on battery plasmoid top.

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/286/#review280
-----------------------------------------------------------


hm. i actually take that "Ship it!" back .. i don't think it makes any sense to change the screen brightness when scrolling over the battery icon. coupled with the fact that there is no user feedback when this happens (other than the screen getting dimmer or brighter ;) this is just asking to annoy people.

click on on the battery to get the controls; how hard is that? =)

- Aaron


On 2008-11-30 16:50:43, Alex Fiestas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.vidsolbach.de/r/286/
> -----------------------------------------------------------
> 
> (Updated 2008-11-30 16:50:43)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> A patch that makes the Battery applet able to increase/decrease the brightness only by scrolling on top.
> 
> 
> Diffs
> -----
> 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdebase/workspace/plasma/applets/battery/battery.h
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdebase/workspace/plasma/applets/battery/battery.cpp
> 
> Diff: http://reviewboard.vidsolbach.de/r/286/diff
> 
> 
> Testing
> -------
> 
> I test it in my computer, also ereslibre test it.
> 
> 
> Thanks,
> 
> Alex
> 
>