Review Request: better behaviour when the tabbar is not a tabwidget
Marco Martin
notmart at gmail.com
Sat Aug 30 19:13:57 CEST 2008
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/167/
-----------------------------------------------------------
Review request for Plasma.
Summary
-------
the tabbar widget can behave both like a tabwidget and a plain tabbar, the behaviour should be a bit different, in particular it did behave really bad when in a panel.
this patch removes the centering and makes the tabbar to take up all the width when it's not like a tabwidget and there is some sizepolicy/preferred sizes setting fixes that makes it behave better in a panel (especially vertical ones)
code probably doesn't look reeeally well, but in particular with that double meaning of tabbar and tabwidget didn't come to my mind something more elegant :)
Diffs
-----
/trunk/KDE/kdebase/workspace/libs/plasma/private/nativetabbar.cpp
/trunk/KDE/kdebase/workspace/libs/plasma/widgets/tabbar.cpp
Diff: http://reviewboard.vidsolbach.de/r/167/diff
Testing
-------
tested in a panel as a plain tabbar (activitybar applet) and as a tabwidget (weather applet)
Thanks,
Marco
More information about the Plasma-devel
mailing list