KDE/kdebase/workspace/plasma/applets/kickoff/ui

[Zack Rusin]

On Thursday 28 August 2008 14:02:00 Alexis Ménard wrote:
> --- trunk/KDE/kdebase/workspace/plasma/applets/kickoff/ui/tabbar.cpp
> #854034:854035 @@ -300,9 +300,9 @@
>          // draw tab text
>          //TODO: we may want a nice animation also for the text
>          if (i != currentTab){
> -            painter.setPen(KColorScheme(QPalette::Active,
> KColorScheme::View,
> Plasma::Theme::defaultTheme()->colorScheme()).foreground().color()); +     
>      
> painter.setPen(QPen(KColorScheme(QPalette::Active).foreground(KColorScheme:
>:InactiveText), 1)); }else{
> -            painter.setPen(Qt::black); //FIXME: we musn't use hardcoded
> color values +           
> painter.setPen(QPen(KColorScheme(QPalette::Active).foreground(KColorScheme:
>:NormalText), 1)); }

It's proly worth noting that you changed the behavior/made it slower. Not sure 
if this is what you intended but:

QPen pen(Qt::black) != QPen pen(Qt::black, 1);
in fact they're fair away. The first one is a cosmetic pen, the second one is 
not (the first one doesn't get transformed the second one does). Qt has a lot 
of optimizations for cosmetic pens.

z