Review Request: PopupApplet iconify patch

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/145/#review137
-----------------------------------------------------------

Ship it!


i think this is useful, don't lke managing it as vertical form factor but wouldn't know how to make it differently, so it's the more simple way i think.
what i would like to see is not applets that are always iconified in the desktop but some function to expand/iconify them (in cntext menu? would it belong to PopupApplet?)


trunk/KDE/kdebase/workspace/libs/plasma/popupapplet.h
<http://reviewboard.vidsolbach.de/r/145/#comment102>

    also a
    bool alwaysIconified()
    would be good


- Marco


On 2008-08-26 05:44:57, Alessandro Diaferia wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.vidsolbach.de/r/145/
> -----------------------------------------------------------
> 
> (Updated 2008-08-26 05:44:57)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> This patch makes easier setting the PopupApplet always "iconified" so that we can avoid regressions. For example kickoff's is always shown when put in the desktop while it would be nicer to have it "iconified" as it happens in the panel.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdebase/workspace/libs/plasma/popupapplet.h
>   trunk/KDE/kdebase/workspace/libs/plasma/popupapplet.cpp
> 
> Diff: http://reviewboard.vidsolbach.de/r/145/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alessandro
> 
>