Review Request: contentsRect() for PanelSvg

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/139/#review130
-----------------------------------------------------------

Ship it!


small comment, but i like the idea.


/trunk/KDE/kdebase/workspace/libs/plasma/panelsvg.cpp
<http://reviewboard.vidsolbach.de/r/139/#comment98>

    if (size.isValid()) ?


- Aaron


On 2008-08-23 10:13:58, Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.vidsolbach.de/r/139/
> -----------------------------------------------------------
> 
> (Updated 2008-08-23 10:13:58)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> a contentsRect() function  to be coherent with graphicsWidget and stuff
> that would make the code using panelsvg more easy if the central element rect is needed, so won't be necessary to poll for the margins and calculate the rect by hand
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/libs/plasma/panelsvg.h
>   /trunk/KDE/kdebase/workspace/libs/plasma/panelsvg.cpp
> 
> Diff: http://reviewboard.vidsolbach.de/r/139/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco
> 
>