Review Request: Transparent system tray icons

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/137/#review127
-----------------------------------------------------------


i'm not sure it makes sense to backport this to 4.1: it's a visual issue, and in an applet that is notoriously flaky. with most of us on trunk/, it's probably better to leave as-is.

for 4.2, i'd rather see the new systray widget working and in trunk instead of continuing to spend time resources on this one.

- Aaron


On 2008-08-17 08:43:00, Jason Stubbs wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.vidsolbach.de/r/137/
> -----------------------------------------------------------
> 
> (Updated 2008-08-17 08:43:00)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Adds transparency to system tray icons through a lot of X11 voodoo - easier to look at the diff. :)
> 
> 
> This addresses bug 158094.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/plasma/applets/systemtray/systemtraycontainer.h
>   /trunk/KDE/kdebase/workspace/plasma/applets/systemtray/systemtraycontainer.cpp
> 
> Diff: http://reviewboard.vidsolbach.de/r/137/diff
> 
> 
> Testing
> -------
> 
> Works pretty much perfectly at 24 bit depth - there's a small flash of white when icons first appear. The colors are slightly off at 16 bit color, but none of the other QImage formats are any better. At 8 bit color, the icons have a static white background.
> 
> 
> Thanks,
> 
> Jason
> 
>