Review Request: a TreeView proxy widget

Aaron Seigo aseigo at kde.org
Wed Aug 20 15:32:24 CEST 2008


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/138/#review126
-----------------------------------------------------------

Ship it!


it looks fine; my only question/concern is whether we have a user for it yet? this one should be easy to find a user for, actually, but i'd like to hold off on things like tables until there are actual widgets wanting to use it so we don't end up with tons of widgets in libplasma, only some of which are used.

- Aaron


On 2008-08-19 11:26:07, Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.vidsolbach.de/r/138/
> -----------------------------------------------------------
> 
> (Updated 2008-08-19 11:26:07)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> This is a proxy widget to a QTreeView, it has the usual plasma widgets functions and uses the new scrollbar.
> Since the scrollbar is private it's needed to be in libplasma to use it, so i would make also the other views like a listview and maybe a table beyond this.
> not sure if make the view transparent since the delegate provided by plasma is not adapt to have a black background, so maybe not.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/libs/plasma/widgets/treeview.cpp
>   /trunk/KDE/kdebase/workspace/libs/plasma/CMakeLists.txt
>   /trunk/KDE/kdebase/workspace/libs/plasma/widgets/treeview.h
> 
> Diff: http://reviewboard.vidsolbach.de/r/138/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco
> 
>



More information about the Plasma-devel mailing list