Review Request: Add missing "All to Desktop" submenu title to taskrmbmenu makeDesktopsMenu() function.

Aaron Seigo aseigo at kde.org
Tue Aug 19 18:31:25 CEST 2008


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/133/#review125
-----------------------------------------------------------

Ship it!


- Aaron


On 2008-08-18 18:13:34, distortedlogic wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.vidsolbach.de/r/133/
> -----------------------------------------------------------
> 
> (Updated 2008-08-18 18:13:34)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> If one uses the taskrmbmenu with the TaskRMBMenu(const TaskList&, bool showAll = true, QWidget *parent = 0) constructor, the "All to Desktop" submenu never has its title set.  This patch makes the submenu call the constructor with its title.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/libs/taskmanager/taskrmbmenu.cpp
> 
> Diff: http://reviewboard.vidsolbach.de/r/133/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> distortedlogic
> 
>



More information about the Plasma-devel mailing list