Review Request: Add missing "All to Desktop" submenu title to taskrmbmenu makeDesktopsMenu() function.

[guitarist198 at yahoo.com]

> On 2008-08-13 07:04:36, Alex Merry wrote:
> > /trunk/KDE/kdebase/workspace/libs/taskmanager/taskrmbmenu.cpp, line 264
> > <http://reviewboard.vidsolbach.de/r/133/diff/2/?file=649#file649line264>
> >
> >     There should be an & before the word "Desktop", as in the makeDesktopsMenu(TaskPtr) method above.
> >     
> >     It might be better to follow that method in setting the title as well, by using setTitle(), rather than a constructor argument.

I have updated the patch to include the suggestions that Alex Merry made.  I am currently unsure about how much time I will have for hacking in the immediate future so I am probably going to hold off on obtaining an svn account.  If someone is available to commit my two verified patches, I would greatly appreciate it.  I will be updating the other patch as well to reduce the work for whoever choses to commit.


- distortedlogic


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/133/#review112
-----------------------------------------------------------


On 2008-08-18 18:13:34, distortedlogic wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.vidsolbach.de/r/133/
> -----------------------------------------------------------
> 
> (Updated 2008-08-18 18:13:34)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> If one uses the taskrmbmenu with the TaskRMBMenu(const TaskList&, bool showAll = true, QWidget *parent = 0) constructor, the "All to Desktop" submenu never has its title set.  This patch makes the submenu call the constructor with its title.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/libs/taskmanager/taskrmbmenu.cpp
> 
> Diff: http://reviewboard.vidsolbach.de/r/133/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> distortedlogic
> 
>