Review Request: Implementation of manual group for tasks applet.

Aaron Seigo aseigo at kde.org
Sun Aug 17 05:45:04 CEST 2008


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/136/#review119
-----------------------------------------------------------


How does this meet up with Christian Mollekopf's work on grouping/sorting in libtaskmanager? If it is a completely separate implementation, then this will have to wait until that is done as Christian has already put a fair amount of time into it and I've already gone through the implementation with him extensively.

This may turn out to be useful as the UI counterpart to his work, but I'm also very skeptical that manual grouping of windows in this manner is really what most people will want. Automated grouping is a lot more useful for most people, and for manual interaction I really think we'll want to think about integration with Activity tagging ...

In any case, the most important thing here is Christian's work and how this relates (if at all) to it.

- Aaron


On 2008-08-16 18:57:20, distortedlogic wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.vidsolbach.de/r/136/
> -----------------------------------------------------------
> 
> (Updated 2008-08-16 18:57:20)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> This is an implementation of manual grouping for the tasks applet.  This allows a user to drag a task onto another to create a group.  They are then prompted to name the group.  More tasks can then be added to this group.  A group may be dragged onto a task and two groups may also be merged.  When groups merge, the user is given a combo box to choose one of the merging groups names or to create a new name for the merged group.  When left clicking a group, a context menu is shown allowing the user to choose one of the windows in the group to activate.  Right clicking invokes a method which utilizes TaskManager::TaskRMBMenu.  The context menu allows the user to rename the group, remove a single task from the group or remove all tasks from the group as well as all the standard choices with the TaskRMBMenu. (Note the All to Desktop submenu of the TaskRMBMenu does not have any text but I also have a patch on reviewboard for this).
> 
> When showOnlyCurrentDesktop is not set, groups are shown on every desktop.  When it is set, a group will only appear on the desktop on which it was created.  If a group is created when the taskmanager is set to show windows from all desktops and then is switched to showOnlyCurrentDesktop, then the group will remove any tasks that are not on its originating desktop (the desktop on which it was created).
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/plasma/applets/tasks/windowtaskitem.h
>   /trunk/KDE/kdebase/workspace/plasma/applets/tasks/windowtaskitem.cpp
>   /trunk/KDE/kdebase/workspace/plasma/applets/tasks/windowtaskgroup.h
>   /trunk/KDE/kdebase/workspace/plasma/applets/tasks/windowtaskgroup.cpp
>   /trunk/KDE/kdebase/workspace/plasma/applets/tasks/CMakeLists.txt
>   /trunk/KDE/kdebase/workspace/plasma/applets/tasks/tasks.h
>   /trunk/KDE/kdebase/workspace/plasma/applets/tasks/tasks.cpp
> 
> Diff: http://reviewboard.vidsolbach.de/r/136/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> distortedlogic
> 
>



More information about the Plasma-devel mailing list