Review Request: setWidget(QGraphicsWidget*) in Plasma::Dialog

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/127/#review111
-----------------------------------------------------------


cool; just a few adjustments necessary


/trunk/KDE/kdebase/workspace/libs/plasma/dialog.h
<http://reviewboard.vidsolbach.de/r/127/#comment81>

    for consistency with PopupApplet, this should be graphicsWidget; also allows us to eventually add a setWidget(QWidget) later on.



/trunk/KDE/kdebase/workspace/libs/plasma/dialog.cpp
<http://reviewboard.vidsolbach.de/r/127/#comment83>

    if this gets called with a different widget, the QVBoxLayout will leak. this should probably be something like:
    
    QVBoxLayout *vbox = dynamic_cast<QVBoxLayout*>(layout());
    
    if (!vbox) {
        vbox = new QVBoxLayout(this);
        ...
    }
    
    if (!d->view) {



/trunk/KDE/kdebase/workspace/libs/plasma/dialog.cpp
<http://reviewboard.vidsolbach.de/r/127/#comment84>

    add: 
    
    d->view->viewport()->setAutoFillBackground(false);



/trunk/KDE/kdebase/workspace/libs/plasma/dialog.cpp
<http://reviewboard.vidsolbach.de/r/127/#comment85>

    this belongs in the if (!d->view) block



/trunk/KDE/kdebase/workspace/libs/plasma/dialog.cpp
<http://reviewboard.vidsolbach.de/r/127/#comment82>

    missing a "delete d->view;" there


- Aaron


On 2008-08-06 07:20:14, Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.vidsolbach.de/r/127/
> -----------------------------------------------------------
> 
> (Updated 2008-08-06 07:20:14)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> now Plasma::Dialog has setWidget(QGraphicsWidget*) used in clockapplet and popupapplet
> there is still the issue of the white background and in popupapplet the widget seems to not want to scale (at least with the calculator where i tried)
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/libs/plasma/dialog.h
>   /trunk/KDE/kdebase/workspace/libs/plasma/dialog.cpp
>   /trunk/KDE/kdebase/workspace/libs/plasma/popupapplet.cpp
>   /trunk/KDE/kdebase/workspace/plasma/applets/libplasmaclock/clockapplet.cpp
> 
> Diff: http://reviewboard.vidsolbach.de/r/127/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco
> 
>