Review Request: setWidget(QGraphicsWidget*) in Plasma::Dialog

[Loïc Marteau]

Marco Martin wrote:
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.vidsolbach.de/r/127/
> -----------------------------------------------------------
>
> Review request for Plasma.
>
>
> Summary
> -------
>
> now Plasma::Dialog has setWidget(QGraphicsWidget*) used in clockapplet and popupapplet
> there is still the issue of the white background and in popupapplet the widget seems to not want to scale (at least with the calculator where i tried)
>   
Hello !

I ve got a perhaps stupid question about that, but i am lacking of 
knowledge and just need to understand...

We have with QT the possibilty to use either qgraphicswidget or qwidget 
via a qproxywidget.

Applets are natively qgraphicswidget.

I have understand than qgraphicswidget are better to use if possible, 
but perhaps it is not as simple and it is not a really "best way in all 
case rule".

Is there case when qwidget is better to use than qgraphicswidget ?

Here we embedded a qgraphicswidget inside a qwidget (Plasma::Dialog), 
why it is more relevant to do that and not directly provide a 
Plasma::GraphicsDialog who not inherits from qwidget but natively from 
qgraphicswidget ?


Thanks for your patience and your helps

Its fun to learn QT and kde hacking in your team
Would really like to thanks all the team for that,

Cheers !

Lo