Review Request: PopupApplet with the expected background

[Aaron Seigo]

> On 2008-08-05 08:17:52, Aaron Seigo wrote:
> > this is, unfortunately, an incorrect approach.
> > 
> > the item should be positioned using Corona::addOffscreenWidget.

in case that wasn't clear enough (probably wasn't, my fault =), this means that having our own scene in popup applet is wrong. the scene should be removed entirely and the Corona should be used instead.


- Aaron


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/125/#review109
-----------------------------------------------------------


On 2008-08-05 07:42:48, Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.vidsolbach.de/r/125/
> -----------------------------------------------------------
> 
> (Updated 2008-08-05 07:42:48)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> when popupapplet was displaying a qgraphicswidget a view with a frame around it and a white background was displayed.
> this should make the background to be the expected applet standard background.
> it does a child graphicsscene that paints the applet background as its own background.
> i'm not sure it's the best way, my idea was to make the view/scene transparent so the background would have been the one of Dialog, but hmm, doesn't seems really possible...
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/libs/plasma/popupapplet.cpp
> 
> Diff: http://reviewboard.vidsolbach.de/r/125/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco
> 
>