Review Request: A simple frame to group widgets

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/117/#review104
-----------------------------------------------------------


the code that is there looks good, but the widget itself does not follow the widget design seen in the other widgets at all.

most importantly, it doesn't support things like stylesheets or text. with text support it would nicely replace not just Frame but also GroupBox as well.

so imho this widget must support text, picture, parentWidget and styleSheet from the standard widget api; it should also support nativeWidget as well and return 0.


/trunk/KDE/kdebase/workspace/libs/plasma/widgets/frame.h
<http://reviewboard.vidsolbach.de/r/117/#comment73>

    setFrameShape



/trunk/KDE/kdebase/workspace/libs/plasma/widgets/frame.h
<http://reviewboard.vidsolbach.de/r/117/#comment75>

    frameShape() const


- Aaron


On 2008-08-01 10:43:55, Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.vidsolbach.de/r/117/
> -----------------------------------------------------------
> 
> (Updated 2008-08-01 10:43:55)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> This thing has a purpose similar to a QFrame, but like the tabwidget the group widget in plasma are not very useful, so it's a qgraphicswidget reimplementation.
> This is quite important as is used by some mockups like http://img70.imageshack.us/img70/9201/wetherfy7.png
> its api is near zero, apart choosing if the appearance is flat, sunken or raised
> i think even things that don't use directly this widget will use its svg, like the sunken effect of the tabbar
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/libs/plasma/CMakeLists.txt
>   /trunk/KDE/kdebase/workspace/libs/plasma/widgets/frame.h
>   /trunk/KDE/kdebase/workspace/libs/plasma/widgets/frame.cpp
> 
> Diff: http://reviewboard.vidsolbach.de/r/117/diff
> 
> 
> Testing
> -------
> 
> grouping for buttons like those screenshots
> 
> 
> Screenshots
> -----------
> 
> frame sunken
>   http://reviewboard.vidsolbach.de/r/117/s/32/
> frame flat
>   http://reviewboard.vidsolbach.de/r/117/s/33/
> 
> 
> Thanks,
> 
> Marco
> 
>