Review Request: Display Artist and Title for shoutcast streams in Amarok.

Trever Fischer tdfischer at fedoraproject.org
Fri Jun 10 14:48:30 CEST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101447/#review3816
-----------------------------------------------------------

Ship it!


Looks good. Please make sure you also make the appropriate change in the plumbing branch for the new playbin2 based pipeline.

- Trever


On May 27, 2011, 1:08 p.m., Elbin Pallimalil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101447/
> -----------------------------------------------------------
> 
> (Updated May 27, 2011, 1:08 p.m.)
> 
> 
> Review request for Phonon Backends and Trever Fischer.
> 
> 
> Summary
> -------
> 
> Clear all metadata except TITLE. Only partially fixes the bug as ALBUM would still display as Streaming data.
> 
> 
> This addresses bug 272929.
>     http://bugs.kde.org/show_bug.cgi?id=272929
> 
> 
> Diffs
> -----
> 
>   gstreamer/mediaobject.cpp d372c1e 
> 
> Diff: http://git.reviewboard.kde.org/r/101447/diff
> 
> 
> Testing
> -------
> 
> Tested with Shoutcast streams.
> 
> 
> Thanks,
> 
> Elbin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/phonon-backends/attachments/20110610/4f0ca87c/attachment.htm 


More information about the Phonon-backends mailing list