Review Request: Fix return value in StreamReader::read

[Harald Sitter]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100701/#review1559
-----------------------------------------------------------

Ship it!


Splendid, I only fixed this in the GStreamer backend when I was fighting with the streamer impl. Indeed we must not indicate an error when 0 bytes were received as this is a perfectly valid scenario (e.g. when the abstractstreamer is waiting for data to arrive, like in the case of a QIODevice's read function).

- Harald


On Feb. 21, 2011, 12:26 p.m., Kamil Klimek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100701/
> -----------------------------------------------------------
> 
> (Updated Feb. 21, 2011, 12:26 p.m.)
> 
> 
> Review request for Phonon and Phonon Backends.
> 
> 
> Summary
> -------
> 
> length parameter was treated as required size to read. It caused for files with id3v1 tags to end playback at begining of the file, because ret value was treated by libvlc as error. Reading id3v1 tags caused to seek almost to end of file and read not as much data as was put in length parameter. After returning length > 0 (we read at least something) everything started to work fine.
> 
> 
> Diffs
> -----
> 
>   vlc/streamreader.cpp 89045da 
> 
> Diff: http://git.reviewboard.kde.org/r/100701/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kamil
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/phonon-backends/attachments/20110221/ee592280/attachment-0001.htm