Review Request: Fix QObject::connect in SeekStack

Harald Sitter sitter at kde.org
Mon Feb 21 17:27:51 CET 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100699/#review1558
-----------------------------------------------------------

Ship it!


http://quickgit.kde.org/?p=phonon-vlc.git&a=commit&h=fd9d417a95391193e5c95a0a6d9a61a92fd95ad1
Pushed, please close this review. Apparently our git hook to do that is a bit broken or I used it wrong :)

- Harald


On Feb. 21, 2011, 10:12 a.m., Kamil Klimek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100699/
> -----------------------------------------------------------
> 
> (Updated Feb. 21, 2011, 10:12 a.m.)
> 
> 
> Review request for Phonon Backends.
> 
> 
> Summary
> -------
> 
> I've finaly reproduced problem with time ticks stop to work for a song. It was because of this timer was connected to itself instead of SeekStack.
> 
> 
> Diffs
> -----
> 
>   vlc/seekstack.cpp 825cc27 
> 
> Diff: http://git.reviewboard.kde.org/r/100699/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kamil
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/phonon-backends/attachments/20110221/0b80762b/attachment-0001.htm 


More information about the Phonon-backends mailing list