Review Request: make sure external subtitles won't override

Sian Cao yinshuiboy at gmail.com
Wed Aug 31 03:36:43 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102429/
-----------------------------------------------------------

(Updated Aug. 31, 2011, 3:36 a.m.)


Review request for Phonon Backends and Harald Sitter.


Summary (updated)
-------

use `local` version of add() function since the user will never know the global index of SD.
using add(void *obj, D descriptor) also have possibility of causing assertion fail.


Diffs
-----

  src/mediacontroller.cpp 3aa7b96 

Diff: http://git.reviewboard.kde.org/r/102429/diff


Testing
-------


Thanks,

Sian

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/phonon-backends/attachments/20110831/c866e307/attachment.html>


More information about the Phonon-backends mailing list