Review Request: Fix metadata emission for http urls.

[Elbin Pallimalil]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101595/
-----------------------------------------------------------

(Updated Aug. 12, 2011, 6:29 p.m.)


Review request for Phonon Backends and Trever Fischer.


Changes
-------

Diff updated to target master.

* I could test this patch only after commenting out the hack
            // Only emit signal if we're on a live stream.
            // Its a kludgy hack that for 99% of cases of streaming should work.
            // If not, this needs fixed in mediaobject.cpp.
            guint kbps;
            g_object_get(that->m_pipeline, "connection-speed", &kbps, NULL);
            if (kbps != 0)

So this patch does not work unless the hack is fixed.


Summary (updated)
-------

Display metadata tags in Amarok for streaming radio. 

(No commit access)


Diffs (updated)
-----

  gstreamer/pipeline.h 47bc786 
  gstreamer/pipeline.cpp 4b98969 

Diff: http://git.reviewboard.kde.org/r/101595/diff


Testing
-------


Thanks,

Elbin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/phonon-backends/attachments/20110812/25937a5e/attachment.html>