Review Request: Use ld.so.conf instead of LD_LIBRARY_PATH when looking for vlc libraries

[Harald Sitter]

> On July 24, 2011, 11:10 p.m., Harald Sitter wrote:
> > this now leads me to the initial thought ^^
> > 
> > why is PHONON_LIB_INSTALL_DIR not equipped with the '64' lib_suffix? seems a bit inconsistent that some stuff would be in lib and other in lib64, so at best I consider this a workaround, setting the cmake var LIB_SUFFIX accordingly would resolve the presented issue nicely.
> > 
> > that said, the proposed change, despite being sort of a workaround, is good so it is worth shipping :)
> 
> Harald Sitter wrote:
>     about the whitespaceness, while indeed not being explicitly mentioned I reckon it is sort of implicit from the code samples :P
>     staying in line with the rest of the file is certainly the rule of thumb though

Did you commit this yet?


- Harald


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102069/#review5072
-----------------------------------------------------------


On July 24, 2011, 11:03 p.m., Valentin Rusu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102069/
> -----------------------------------------------------------
> 
> (Updated July 24, 2011, 11:03 p.m.)
> 
> 
> Review request for Phonon Backends and Harald Sitter.
> 
> 
> Summary
> -------
> 
> GwenView crashed in Phonon-VLC module when previewing video files.
> When investigating the crash, I found out that libvlc was not found on my system because the code only searched for it using the LD_LIBRARY_PATH variable. On my system, this variable wasn't set to /usr/lib64 where libvlc lives. So I adjusted the code to use ld.so.conf file which is always correctly set by the system.
> 
> 
> Diffs
> -----
> 
>   src/libvlc.cpp 4d3ed45 
> 
> Diff: http://git.reviewboard.kde.org/r/102069/diff
> 
> 
> Testing
> -------
> 
> GwenView no longer crashes when encountering video file, but now it's correctly previewing them :-)
> 
> I also searched for open bug reports but found no bug directly related to my issue.
> However the bug 259269 may be resolved by this patch.
> 
> 
> Thanks,
> 
> Valentin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/phonon-backends/attachments/20110812/66ca83b5/attachment.html>