Review Request: Display Artist and Title for shoutcast streams in Amarok.

[Harald Sitter]

> On June 10, 2011, 12:48 p.m., Trever Fischer wrote:
> > Looks good. Please make sure you also make the appropriate change in the plumbing branch for the new playbin2 based pipeline.
> 
> Elbin Pallimalil wrote:
>     I don't have commit access to commit the changes. This fix does not look appropriate for the plumbing branch, I can submit a different set of changes for review for the plumbing branch.

plumbing is now merged into master, so you might want to take another look at this, shouldn't be too much work though from what I have seen :)

BTW, if you mention that you don't have commit access in the description we can process a good quality patch faster as we'll commit it right away :)


- Harald


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101447/#review3816
-----------------------------------------------------------


On May 27, 2011, 1:08 p.m., Elbin Pallimalil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101447/
> -----------------------------------------------------------
> 
> (Updated May 27, 2011, 1:08 p.m.)
> 
> 
> Review request for Phonon Backends and Trever Fischer.
> 
> 
> Summary
> -------
> 
> Clear all metadata except TITLE. Only partially fixes the bug as ALBUM would still display as Streaming data.
> 
> 
> This addresses bug 272929.
>     http://bugs.kde.org/show_bug.cgi?id=272929
> 
> 
> Diffs
> -----
> 
>   gstreamer/mediaobject.cpp d372c1e 
> 
> Diff: http://git.reviewboard.kde.org/r/101447/diff
> 
> 
> Testing
> -------
> 
> Tested with Shoutcast streams.
> 
> 
> Thanks,
> 
> Elbin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/phonon-backends/attachments/20110812/09afd580/attachment.html>