Review Request: reset m_hasVideo when some events occurred

Harald Sitter sitter at kde.org
Thu Aug 4 10:27:56 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102207/#review5381
-----------------------------------------------------------


Good catch!

I think at this point it might make sense to create a general reset function though, resetting the video member and calling resetMediaController.

- Harald


On Aug. 4, 2011, 9:52 a.m., Sian Cao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102207/
> -----------------------------------------------------------
> 
> (Updated Aug. 4, 2011, 9:52 a.m.)
> 
> 
> Review request for Phonon Backends and Harald Sitter.
> 
> 
> Summary
> -------
> 
> this fix problem when start to play next source, m_hasVideo is true and MediaObject data won't get resetted.
> 
> 
> Diffs
> -----
> 
>   src/mediaobject.cpp 1cc38ab 
> 
> Diff: http://git.reviewboard.kde.org/r/102207/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sian
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/phonon-backends/attachments/20110804/1fbe19e7/attachment.html>


More information about the Phonon-backends mailing list