Review Request: multichannel support.

[Trever Fischer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102018/#review5296
-----------------------------------------------------------


Still need to address the noise in the header file.


gstreamer/audiodataoutput.h
<http://git.reviewboard.kde.org/r/102018/#comment4794>

    Noisy changes that just add more work for us to undo as soon as your patch is committed.



gstreamer/audiodataoutput.h
<http://git.reviewboard.kde.org/r/102018/#comment4795>

    QAtomicInt doesn't guarantee thread safety for the purposes of this code.


- Trever


On Aug. 1, 2011, 7:14 a.m., Alessandro Siniscalchi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102018/
> -----------------------------------------------------------
> 
> (Updated Aug. 1, 2011, 7:14 a.m.)
> 
> 
> Review request for Phonon Backends.
> 
> 
> Summary
> -------
> 
> Now the object support the multichannel feature requested by specification.
> 
> 
> Diffs
> -----
> 
>   gstreamer/audiodataoutput.h 05cc497c347423a2f910ddab4aff5e9139fd5e06 
>   gstreamer/audiodataoutput.cpp 744b64db125fb17d44f5689f642008a197381490 
> 
> Diff: http://git.reviewboard.kde.org/r/102018/diff
> 
> 
> Testing
> -------
> 
> only with 2 channel file.
> Send me a multichannel one (stoner music please)!
> 
> 
> Thanks,
> 
> Alessandro
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/phonon-backends/attachments/20110801/3eed5796/attachment.html>