about a patch

[Thierry Bastian]

That patch is good for me.

Thanks for your time BTW.

Thierry

-----Original Message-----
From: Matthias Kretz [mailto:kretz at kde.org] 
Sent: mardi 25 novembre 2008 16:22
To: phonon-backends at kde.org
Subject: Re: about a patch

On Tuesday 25 November 2008 15:25:07 Richard wrote:
> >> Then you can:
> >> mediaObject->setCurrentSource(MediaSource());
> >
> > Yes, which should be treated as the application doing something 
> > wrong (not fatal, though), whether we want to handle it the same as 
> > MediaSource::Empty I'm not sure about yet.
>
> MediaSource source();
> Q_ASSERT(source.type() == Empty);
> mediaObject->setCurrentSource(source); // Remove currently loaded media.
>
> ...would make sense to me (then there would be not need for the static 
> function, alltough I don't think it so bad).

Hmm, so we'd redefine the meaning of MediaSource() from Invalid to Empty. 
Perhaps the most sensible way. Dunno why I rejected that when thinking about
it...

New patch attached.

--
________________________________________________________
Matthias Kretz (Germany)                            <><
http://Vir.homelinux.org/