about a patch

[Matthias Kretz]

On Monday 24 November 2008 12:10:37 Matthias Kretz wrote:
> As I said, I'm looking into making phonon-xine work without the
> setNextSource call. I'm confident this is going to work, so we could revert
> the revert in trunk then.

Phonon-Xine in trunk can now act correctly without the call to 
setNextSource(MediaSource()). I'm fine with removing it in trunk now.

> But I also had the idea of introducing Empty or Unset to MediaSource::Type.
> Then Invalid would keep its meaning of doing something wrong in the
> application while Empty/Unset would tell Phonon to actually do something:
> unset the current source. What do you think?

I have a patch attached. Please review.

-- 
________________________________________________________
Matthias Kretz (Germany)                            <><
http://Vir.homelinux.org/

-------------- next part --------------
A non-text attachment was scrubbed...
Name: empty-mediasource.patch
Type: text/x-patch
Size: 4800 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/phonon-backends/attachments/20081125/41ab187c/attachment.patch