Review Request: [Phonon] Updated patch, add audio and subtitle support

Ian Monroe ian.monroe at gmail.com
Wed Mar 12 22:17:49 CET 2008


 -----------------------------------------------------------
 This is an automatically generated e-mail. To reply, visit:
 http://mattr.info/r/291/
 -----------------------------------------------------------

 Review request for kdelibs and Matthias Kretz.


 Summary
 -------

 *So since Kretz and I figured out that multiple video streams and
multiple angles are probably the same thing, VideoStreamDescription
stuff has been removed.
 *Also moving subtitle and audio channel selection to MediaController.
This actually simplifies things quite a bit, since AddonInterface is
easy to... add on to.

 What isn't done: signals. It really needs a signal for new audio and
new subtitles. I'll work on this next, but this can go into kdelibs
now.


 Diffs
 -----

  trunk/KDE/kdelibs/phonon/addoninterface.h
  trunk/KDE/kdelibs/phonon/mediacontroller.h
  trunk/KDE/kdelibs/phonon/mediacontroller.cpp
  trunk/KDE/kdelibs/phonon/mediaobject.h
  trunk/KDE/kdelibs/phonon/mediaobject.cpp
  trunk/KDE/kdelibs/phonon/mediaobject_p.h
  trunk/KDE/kdelibs/phonon/mediaobjectinterface.h
  trunk/KDE/kdelibs/phonon/objectdescription.h
  trunk/KDE/kdelibs/phonon/objectdescription.cpp
  trunk/KDE/kdelibs/phonon/tests/fakebackend/mediaobject.h
  trunk/KDE/kdelibs/phonon/tests/fakebackend/mediaobject.cpp

 Diff: http://mattr.info/r/291/diff


 Testing
 -------

 I've created a corresponding changes for phonon-xine and Dragon
Player as well, so I've tested the patch in this way.

 I plan on committing the changes phonon-xine after cleaning it up a
bit and this patch is committed.


 Thanks,

 Ian


More information about the Phonon-backends mailing list