[Patch] About chapters and titles...

[Tanguy Krotoff]

Here is the patch fixing the issue presented below.
It adds new methods with TitleDescription and ChapterDescription
parameters rather than just an int parameter.
It keeps compatibility with the previous MediaController class.

Currently the patch modify MediaController class, another option would
be to create a MediaController2 that inherits from MediaController.

This patch allows this (a screenshot is better than a long speech):
http://phonon-vlc-mplayer.googlegroups.com/web/advanced_chapters_titles.png?gsc=VE5gPAsAAAAE42j8hvYXBK9EpfBpP3R1
Here you can see a before/after comparison with the MPlayer backend.

On Sun, Apr 27, 2008 at 11:52 AM, Tanguy Krotoff <tkrotoff at gmail.com> wrote:
>  Currently for dealing with chapters (and titles) we have:
>
>  void setCurrentChapter(int chapterNumber);
>  int availableChapters() const;
>  int currentChapter() const;
>
>  A chapter/title is just an int.
>
>  Since there is no Description object, it is not possible to give to
>  the user more informations like title duration (DVD) or chapter's
>  title (mkv format support this).
>
>  IMHO, by switching to Description objects for chapters and titles (I
>  don't see the need for angles), we can provide this while keeping the
>  API consistent and symmetric.
>
>  I can send a patch but as you mention before, we cannot break API/ABI
>  compatibility, so what solution do you propose for this?

-- 
Tanguy Krotoff <tkrotoff at gmail.com>
+33 6 68 42 70 24
-------------- next part --------------
A non-text attachment was scrubbed...
Name: extended_chapters_titles.patch
Type: application/octet-stream
Size: 11046 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/phonon-backends/attachments/20080430/6617b497/attachment.obj