[Parley-devel] Re: [PATCH] Added dictation practice.

[Frederik Gladhorn]

Hi Massimo,

thanks for your patch :)

Please include the files in Review Board. The way to do that is to simply use 
svn add on the files that you created.
Also you have some unrelated changed to the top level CMakeLists.txt, please 
remove those.

What do you plan to do when there is no sound file? Currently that makes it 
unusable.

I am wondering if we could make this part of the normal written practice 
somehow. The list of practice modes is already too long.

Cheers,
Frederik

On Wednesday 16. February 2011 01.14.52 Massimo Lo Iacono wrote:
> Hallo.
> 
> I just sent a review request in Review Board for kdeedu group. Here I
> attach the 4 files too.
> 
> I have made the modifications to add functionality for dictation practice.
> 
> Dictation is a monolanguage type of practice. It consists a sound (only)
> question and a text solution in the same language of question.
> 
> The language of practice is the first of the pair languageFrom/languageTo.
> 
> For developers:
> 
> Since the dictation practice is of the type monolanguage and the pre
> existent code was for bilanguage practice, I modified a bit the code in
> order that now it is adapt also for a monolanguage type of practice.
> 
> I added these new 4 files in "src/4/kdeedu/parley/src/practice/" directory:
> 
>   dictationbackendmode.h
>   dictationbackendmode.cpp
>   dictationmodewidget.h
>   dictationmodewidget.cpp
> 
> IMPORTANT: to manage the visualisation of question and solution images, I
> was forced to create the new function:
> 
>   GuiFrontend::compareImage()
> 
> and to modify the functions:
> 
>   AbstractBackendMode::setTestEntry
>   MultipleChoiceBackendMode::setTestEntry
>   ConjugationBackendMode::setTestEntry
>   ComparisonBackendMode::setTestEntry
> 
> adding the rows:
> 
>   m_frontend->setQuestionImage
>   m_frontend->setSolutionImage
>   m_frontend->compareImage();
> 
> I created the patch from the 1218525 revision, almost 2 weeks old.
> 
> I can successful compile and execute the code with my modifications.
> 
> Massimo Lo Iacono
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/parley-devel/attachments/20110305/e94e7a12/attachment.sig