[PATCH] Config Dialog for Runners

[Jordi Polo]

On Mon, May 19, 2008 at 4:08 PM, Ryan P. Bitanga <ryan.bitanga at gmail.com>
wrote:

> 2008/5/19 Aaron J. Seigo <aseigo at kde.org>:
> > On Sunday 18 May 2008, Ryan P. Bitanga wrote:
> >> Anyway, attached is a preliminary patch to support a config dialog for
> >> KRunner.
> >
> > hm .... this is really bad timing =) we are hoping to get a series of
> changes
> > in tomorrow to beat the feature freeze and have a branch going .. this
> will
> > need to be merged into the branch. =/
>
> Well I was worried it wouldn't make it because I thought everything
> had to be fixed by May 17 and it's May 19 my time already.
>
> >
> > also, we'll need to take scripting into consideration with the change to
> a kcm
> >
> > KConfigGroup* RunnerManager::config() should be KConfigGroup
> > RunnerManager::config() (no pointer)
> >
> > we'll need to allow for scripting somehow with regards to the
> configuration
> > now that it uses KCMs instead. hm... not sure how to do that off hand,
> but it
> > will need to get done.
> >
> > i'm still not overly happy about the whitelist approach as it means every
> > newly installed runner will need to be added either by the user (not
> > desirable) or automatically with the right key in the config file ...
> > essentially working around the policy. what we really want is an opt-in
> > blacklist, not an opt-in whitelist.
>
> Well changing it from a whitelist to a blacklist is as simple as
> changing a line in loadRunners() i.e. selected =
> !description.isPluginEnabled(). :) But in my opinion that would make
> it confusing.
>
> And I think it would be better if we just set
> X-KDE-PluginInfo-EnabledByDefault=true in the desktop files.
>

I think we have argued about this at least two times before. As Aseigo has
stated clearly his preference for blacklisting and you failed to convince
us, it is too late for more arguing :P
BTW, I've been missing lately,  I don't expect to have much time till at
least the release of 4.1.


A quick KActionSelector GUI can be hacked for the general configuration of
RunnerManager, we are just out of schedule though... Left to 4.2?


> > the big issue, however, is the timing of this. i'd say commit everything,
> but
> > please change the whitelisting approach. commit either within the next 12
> > hours so that a merge can be done with the branch or else hold off and
> wait
> > for 4.2. =( in fact here's what i'll do: if you don't get it committed by
> > noon my time i'll just commit it for you with some modifications so that
> i
> > can also merge it into the branch and be done with it.
>
> I don't think I can commit it myself within 12 hours since my personal
> laptop is at home and I'm working late today. :( So please do commit
> it for me.
>
> Cheers,
> Ryan
> _______________________________________________
> Panel-devel mailing list
> Panel-devel at kde.org
> https://mail.kde.org/mailman/listinfo/panel-devel
>



-- 
Jordi Polo Carres
NLP laboratory - NAIST
http://www.bahasara.org
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/panel-devel/attachments/20080519/dc228c43/attachment.html