[PATCH] mousewheel on taskbar resumed
    Aaron J. Seigo 
    aseigo at kde.org
       
    Sat May 17 00:00:11 CEST 2008
    
    
  
On Friday 16 May 2008, Marco Martin wrote:
> hmm, comments?
+    //if active initialize m_activeTask at the last item inserted
+    if (task->isActive()) {
+        m_activeTask = m_windowTaskItems.end() - 1;
+    }
assumes it gets inserted at the end. why not:
m_activeTask = m_windowTaskItems.find(task);?
Tasks::wheelEvent looks a little dangerous; what happens when a task is 
removed but no other window becomes active? (e.g. multiple desktops, only one 
window on current desktop, window is closed). the iterator will now be 
invalid, correct?
-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43
KDE core developer sponsored by Trolltech
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 194 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/panel-devel/attachments/20080516/24ce2e3d/attachment.pgp 
    
    
More information about the Panel-devel
mailing list