Should methods in scripting/scriptengine.h have PLASMA_EXPORT?

Aaron J. Seigo aseigo at kde.org
Mon May 12 20:57:44 CEST 2008


On Monday 12 May 2008, Richard Dale wrote:
> The five methods in the Plasma:: namespace in the scripting/scriptengine.h
> header don't have PLASMA_EXPORT macros and so you can't link to them
> outside the Plasma lib.

the packageStructure one should certainly be exported. the others are only 
used internally right now ..... but it is in a publicly exported header and 
likely *should* be part of the public APIgood catch, please commit your patch 
=)

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Trolltech
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 194 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/panel-devel/attachments/20080512/daaa660d/attachment.pgp 


More information about the Panel-devel mailing list