[REVIEW] Improved applet drag&drop support

[Riccardo Iaconelli]

2008/5/10 Rob Scheepmaker <r.scheepmaker at student.utwente.nl>:

> On Sat, May 10, 2008 at 07:19:20PM +0200, Rob Scheepmaker wrote:
> > Hi,
>

Hi!


>
> >
> > I've improved my drag&drop patch some more. This patch tries to improve
>
> Maybe I should include the patch... :s
>  <https://mail.kde.org/mailman/listinfo/panel-devel>
>

I've not tried it, but the patch *looks* good to me.
Just a single nitpick:

* applet.h: "The view wher e" -> typo =)

And a suggestion:

* applethandle.cpp: //TODO: is there a window flag to make this not appear
in the task manager?
  I'm sure there is something, yakuake does it. maybe ask Sho or have a look
at the codebase?

For the rest it looks pretty well written, unless I'm on crack. =)

Bye,
-Riccardo
-- 
GPG key:
3D0F6376
When encrypting, please encrypt also for this subkey:
9EBD7FE1
-----
Pace Peace Paix Paz Frieden Pax Pokój Friður Fred Béke 和平
Hasiti Lapé Hetep Malu Mир Wolakota Santiphap Irini Peoch שלום
Shanti Vrede Baris Rój Mír Taika Rongo Sulh Mir Py'guapy 평화
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/panel-devel/attachments/20080511/7f871af7/attachment.html