Review Request: some bits for taskbar theming

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://mattr.info:8080/r/353/#review328
-----------------------------------------------------------


changes look alright... and yes, Task::bestIcon is rather old code. libtaskmanager could probalby use some love at some point.

- Aaron


On 2008-05-02 08:42:52, Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://mattr.info:8080/r/353/
> -----------------------------------------------------------
> 
> (Updated 2008-05-02 08:42:52)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> this patch apart from better margin calculations for the icon text tries to load less blurry icons for the tasks.
> at the moment the tasks icons looks really terrible, because a big icon gets loaded and then the pixmap scaled down, with this patch it looks a little bit better but still wrong
> don't know if it will be possible to load the right sized icon withut going to tweak (ouch!) KWindowSystem or workspace/Taskmanager? (where btw Task::bestIcon seems to be really broken...)
> at the moment i would commit the margins calculation part and hold the icon size thing maybe?
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/plasma/applets/tasks/windowtaskitem.h
>   /trunk/KDE/kdebase/workspace/plasma/applets/tasks/windowtaskitem.cpp
> 
> Diff: http://mattr.info:8080/r/353/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco
> 
>