KDE/kdebase/workspace/libs/plasma

[Aaron J. Seigo]

On Friday 02 May 2008, Marco Martin wrote:
> SVN commit 803217 by mart:
>
> don't erase the entire cache when updating the sizes of a single panel,
> so the cache for multiple items now actually works :)

> @@ -512,7 +513,6 @@
>  void PanelSvg::Private::updateSizes()
>  {
>      //kDebug() << "!!!!!!!!!!!!!!!!!!!!!! updating sizes" << prefix;
> -    q->clearCache();

doesn't this mean that now when you change the size, then change the prefix 
that you end up with an incorrect cached item?

the size is global to the object, not the individual panel? if not, then the 
API is very misleading as resizePanel actually doesn't do what it suggests; 
instead it resizes just the current prefix, meaning you *must* call 
resizePanel after each call to setPrefix if you want the same size panel.

moreover, this change breaks caching in the case of setImageCache and 
setEnabledBorders.

either these methods are per-cached-panel (which is very counter-intuitive?) 
or they are per-PanelSvg object.

what use case are you trying to fix exactly?

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Trolltech
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 194 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/panel-devel/attachments/20080502/20b3725c/attachment.pgp