Review Request: [engineexplorer] Some more improvements

Aaron Seigo aseigo at kde.org
Thu May 1 20:03:54 CEST 2008


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://mattr.info:8080/r/347/#review327
-----------------------------------------------------------


i've committed the patch with additional i18n fixes..


/trunk/KDE/kdebase/workspace/plasma/tools/engineexplorer/engineexplorer.cpp
<http://mattr.info:8080/r/347/#comment224>

    these plural items should be in the form: i18nc("<%1 singular>", "<%1 plural>", value);


- Aaron


On 2008-05-01 12:48:09, Gilles Chauvin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://mattr.info:8080/r/347/
> -----------------------------------------------------------
> 
> (Updated 2008-05-01 12:48:09)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> * Added some missing i18n()'s
> * Added QBitArray()s size
> * Added QByteArray()s size when QVariant::toString() returns an empty string (because the array is empty or simply can not be converted to a QString)
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/plasma/tools/engineexplorer/engineexplorer.cpp
> 
> Diff: http://mattr.info:8080/r/347/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gilles
> 
>



More information about the Panel-devel mailing list