Review Request: 1 root-widget per xinerama/mergedfb/xrandr-screen

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://mattr.info:8080/r/345/#review326
-----------------------------------------------------------

Ship it!


great work =) hopefully the kwin patch will get accepted shortly.

- Aaron


On 2008-05-01 03:52:08, Aike Sommer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://mattr.info:8080/r/345/
> -----------------------------------------------------------
> 
> (Updated 2008-05-01 03:52:08)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> This patch will make plasma(-the-app) use one root-widget per screen, thus working around intels 2048px texture-size limit.
> 
> It completely gets rid of RootWidget and uses DesktopView as the real root-widgets...
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/plasma/plasma/CMakeLists.txt
>   /trunk/KDE/kdebase/workspace/plasma/plasma/desktopview.h
>   /trunk/KDE/kdebase/workspace/plasma/plasma/desktopview.cpp
>   /trunk/KDE/kdebase/workspace/plasma/plasma/plasmaapp.h
>   /trunk/KDE/kdebase/workspace/plasma/plasma/plasmaapp.cpp
>   /trunk/KDE/kdebase/workspace/plasma/plasma/rootwidget.h
>   /trunk/KDE/kdebase/workspace/plasma/plasma/rootwidget.cpp
> 
> Diff: http://mattr.info:8080/r/345/diff
> 
> 
> Testing
> -------
> 
> This relies on another patch to kwin to allow desktop-windows to only cover 1 screen instead of everything, i sent that to the kwin-list.
> In all other WMs i have on my system (compiz, e16, twm) this works out of the box, only kwin-3 fails, probably due to the same behavior as in kwin-4.
> 
> 
> Thanks,
> 
> Aike
> 
>