kickoff tabbar touch-ups

Sebastian Kügler sebas at kde.org
Wed Mar 26 13:21:43 CET 2008


On Wednesday 26 March 2008 13:10:38 Dmitry Suzdalev wrote:
> On Wednesday 26 March 2008 12:30:58 Sebastian Kuegler wrote:
> > (a) The toolbar text under the buttons in applications defaults to the
> > same size as smallestReadableFont(), I've made the same visual change to
> > kickoff in this patch.
> >
> > (b) The patch also adds a bit of spacing next to the labels of the tabs
> > so it doesn't look too cramped.
> >
> > Those changes are independant from each other, can I commit (a), (b) or
> > both? See the screenshots for the result with both patches applied.
> >
> > http://vizzzion.org/tmp/before.jpg
> > http://vizzzion.org/tmp/after.jpg
>
> Even with this change it still looks odd on my system. Only "Leave" tab has
> acceptable width - other labels are waaay to close to tab's borders
> (screenshot attached);

Hmm ... 

> I think what's really needed to fix this is to use QFontMetrics to find out
> string width and adjust tab size accordingly.

That's what the code does. I've only addes 4 pixels to that width. I can have 
another look at it once I'm back home at my development setup...
-- 
sebas

 http://www.kde.org | http://vizZzion.org |  GPG Key ID: 9119 0EF9 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 481 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/panel-devel/attachments/20080326/dbfe13b3/attachment.pgp 


More information about the Panel-devel mailing list