[PATCH] Re: Applet positions
Ivan Čukić
ivan.cukic at gmail.com
Tue Mar 25 09:54:19 CET 2008
> one thing i would request, however, is adding a comment that explains what
> is going on. it's not going to be immediately apparent to most people what
> you were thinking, so for maintainability a comment is pretty much required
> here.
You mean something like "we are multiplying newGeometry.left() with the
subtracted newSize.width() from geometry().width()...
Just joking :)
Here's the fixed patch - with comments and a small fix (I always forget that
the layout is not a parenting element so that it has it's own topLeft location
which doesn't need to be 0,0)
If nobody complains, I'll commit it later today...
--
Those people who think they know everything are a great annoyance to those of
us who do.
-- Isaac Asimov
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freelayout-relative.diff
Type: text/x-patch
Size: 2964 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/panel-devel/attachments/20080325/120087e0/attachment.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/panel-devel/attachments/20080325/120087e0/attachment.pgp
More information about the Panel-devel
mailing list