[Bug 159713] New: [PATCH] Notes config dialog should use nicer font and color selection widgets

[David Benjamin]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=159713         
           Summary: [PATCH] Notes config dialog should use nicer font and
                    color selection widgets
           Product: plasma
           Version: unspecified
          Platform: Compiled Sources
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: wishlist
          Priority: NOR
         Component: widget-misc
        AssignedTo: panel-devel kde org
        ReportedBy: dnas.dnas gmail com


Version:            (using Devel)
Installed from:    Compiled sources

(Is this the right category?)

The below patch makes the notes applet use KFontRequester and KColorButton for configuration.

This also fixes a couple FIXMEs and TODOs, but adds one of it's own:

So, the old code used QColor() as the default color to be used, which makes "an invalid color with the RGB value (0, 0, 0)". This caused problems with the KColorButton's default color display, so I changed it to use Qt::black, but I expect it really should get it from the Plasma theme. I tried using m_textArea->defaultTextColor(), i.e. the one the LineEdit came with, but that appears to use Plasma::Theme::textColor(), which is the default to use on the normal background, which is white on most themes.