[PATCH] fix panel sizing

Chani chanika at gmail.com
Sat Mar 22 09:46:07 CET 2008


review board is down for easter, so we're back to the old-fashioned method.

this fixes the panel sizing perfectly for me; I don't think it should cause 
any trouble with multiple screens, but please test anyways.

in this patch I had to set default values in the constructor to prevent 
problems when there is no config file; what I don't understand is why I had 
to set *all* the default constraints and not just some. or rather, why it 
worked in the first place. if screen and location are set but not formfactor, 
then there's some weird insanity where the panel's applets are set up before 
the panel has a chance to run constraintsUpdated, and the applets get 
confused about where to put themselves. but if screen and location are left 
alone (resulting in an incorrect default panel size) then the applets are 
fine.

-- 
This message brought to you by evyl bananas, and the number 3.
www.chani3.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: panel-size.diff
Type: text/x-diff
Size: 2880 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/panel-devel/attachments/20080322/1294da7a/attachment.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/panel-devel/attachments/20080322/1294da7a/attachment.pgp 


More information about the Panel-devel mailing list